Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add const FLASH_ERASE_VALUE #533

Closed
wants to merge 1 commit into from
Closed

Add const FLASH_ERASE_VALUE #533

wants to merge 1 commit into from

Conversation

ExplodingWaffle
Copy link
Contributor

Adds a const for erase value next to the other flash consts. (working on adding erase value to embedded-storage and embassy-boot. this seems nice to have anyway)

@Dirbaio
Copy link
Member

Dirbaio commented Jan 1, 2025

This info is already exposed in METADATA. embassy-stm32 can read it from there in build.rs and generate consts or use it in embedded-storage impls.

I'd prefer avoiding adding more consts stm32-metapac, and gradually change everything to go through METADATA. It's more "general" than consts, it allows consumers to generate anything they want in build.rs. (The existing consts predate METADATA, they're from a time stm32-metapac exported info through very cursed macros instead)

@Dirbaio Dirbaio closed this Jan 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ExplodingWaffle @Dirbaio